fix: modernize Hole.pm preamble and fix POD typos#13
Merged
toddr merged 1 commit intocpan-authors:mainfrom Mar 22, 2026
Merged
Conversation
- require 5.005 → use 5.014 to match MIN_PERL_VERSION in Makefile.PL - Add 'use warnings' for better diagnostics - Replace 'use vars' with 'our' (available since Perl 5.6) - Fix POD typos: dinamically, occured, constrtucted, refered, assuption Co-Authored-By: Claude Opus 4.6 <[email protected]>
toddr
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modernize the module preamble and fix documentation typos.
Why
require 5.005contradictsMIN_PERL_VERSION => '5.014'in Makefile.PL — the in-code version requirement should match the build system. While at it, enableuse warningsand replaceuse varswithour(both available since 5.6, well within the 5.014 floor).How
require 5.005→use 5.014(matches Makefile.PL)use warningsuse vars qw(...)→ourdeclarationsTesting
Full test suite passes (84 tests, 5 files) on Perl 5.42.
🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 11 insertions(+), 15 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline